mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields
Date Sun, 03 Jan 2016 09:50:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review112442
-----------------------------------------------------------

Ship it!


Great. I'm fixing the pointer style as I commit.


src/tests/common/http_tests.cpp (line 87)
<https://reviews.apache.org/r/41381/#comment172916>

    `s/IPAddress */IPAddress* /`



src/tests/slave_tests.cpp (lines 2206 - 2209)
<https://reviews.apache.org/r/41381/#comment172915>

    `s/IPAddress */IPAddress* /`


- Adam B


On Dec. 29, 2015, 10:44 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 10:44 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message