mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.
Date Sun, 03 Jan 2016 07:02:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41861/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
-------

Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

According to Docker v2 image manifest spec, v1Compatibility is a string containing a raw JSON
object. The raw JSON object is v1::ImageManifest. This patch fixed the bug in the original
code.


Diffs
-----

  src/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
  src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 049d46cad5cf94a3fb5d74cbfe649850311d35ad

  src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f


Diff: https://reviews.apache.org/r/41861/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message