From reviews-return-16597-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Dec 4 22:56:52 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBCB11807F for ; Fri, 4 Dec 2015 22:56:51 +0000 (UTC) Received: (qmail 75800 invoked by uid 500); 4 Dec 2015 22:56:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 75776 invoked by uid 500); 4 Dec 2015 22:56:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 75757 invoked by uid 99); 4 Dec 2015 22:56:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 22:56:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DCDC92EA59E; Fri, 4 Dec 2015 22:56:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8884140046316756994==" MIME-Version: 1.0 Subject: Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer. From: "Gilbert Song" To: "Artem Harutyunyan" , "Timothy Chen" Cc: "Gilbert Song" , "Mesos ReviewBot" , "mesos" Date: Fri, 04 Dec 2015 22:56:45 -0000 Message-ID: <20151204225645.1719.33815@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Gilbert Song" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40884/ X-Sender: "Gilbert Song" References: <20151202221614.7624.88936@reviews.apache.org> In-Reply-To: <20151202221614.7624.88936@reviews.apache.org> Reply-To: "Gilbert Song" X-ReviewRequest-Repository: mesos --===============8884140046316756994== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40884/ ----------------------------------------------------------- (Updated Dec. 4, 2015, 2:56 p.m.) Review request for mesos, Artem Harutyunyan and Timothy Chen. Bugs: MESOS-4051 https://issues.apache.org/jira/browse/MESOS-4051 Repository: mesos Description ------- Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer. Diffs (updated) ----- src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e Diff: https://reviews.apache.org/r/40884/diff/ Testing ------- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song --===============8884140046316756994==--