----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109032 ----------------------------------------------------------- Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` to this review (and future CMake reviews)? --- Ran `cmake .. && make` on OSX. Hit this error: ``` mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: 'linux/sched.h' file not found #include ``` Note that `src/Makefile.am` does this: ``` if OS_LINUX libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES) else EXTRA_DIST += $(MESOS_LINUX_FILES) endif ``` And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`. - Joseph Wu On Dec. 4, 2015, 10:30 a.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40951/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 10:30 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Initial set of source files missing for cmake agent binary. > > > Diffs > ----- > > src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef > > Diff: https://reviews.apache.org/r/40951/diff/ > > > Testing > ------- > > Tested to make sure library builds successfully. > > > Thanks, > > Diana Arroyo > >