| Adam B |
Re: Review Request 41075: Added support for implicit roles. |
Tue, 08 Dec, 08:26 |
| Adam B |
Re: Review Request 41075: Added support for implicit roles. |
Thu, 10 Dec, 10:13 |
| Adam B |
Re: Review Request 40431: Move RoleInfo message out of allocator.proto |
Thu, 10 Dec, 10:40 |
| Adam B |
Re: Review Request 40469: Update Allocator interface to support dynamic roles |
Thu, 10 Dec, 10:46 |
| Adam B |
Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo |
Tue, 15 Dec, 01:47 |
| Adam B |
Re: Review Request 40829: Improved authorization documentation. |
Tue, 15 Dec, 01:48 |
| Adam B |
Re: Review Request 40829: Improved authorization documentation. |
Tue, 15 Dec, 05:21 |
| Adam B |
Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo |
Tue, 15 Dec, 05:32 |
| Adam B |
Re: Review Request 41075: Added support for implicit roles. |
Tue, 15 Dec, 09:56 |
| Adam B |
Re: Review Request 40995: Added test cases for role behavior. |
Tue, 15 Dec, 10:18 |
| Adam B |
Re: Review Request 35711: Disallow special characters in role name. |
Tue, 15 Dec, 10:45 |
| Adam B |
Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task. |
Tue, 15 Dec, 11:08 |
| Adam B |
Re: Review Request 35711: Disallow special characters in role name. |
Tue, 15 Dec, 11:11 |
| Adam B |
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port |
Tue, 15 Dec, 11:15 |
| Adam B |
Re: Review Request 41075: Added support for implicit roles. |
Wed, 16 Dec, 22:31 |
| Adam B |
Re: Review Request 40431: Move RoleInfo message out of allocator.proto |
Wed, 16 Dec, 22:59 |
| Adam B |
Re: Review Request 41075: Added support for implicit roles. |
Thu, 17 Dec, 00:37 |
| Adam B |
Re: Review Request 40431: Move RoleInfo message out of allocator.proto |
Thu, 17 Dec, 00:45 |
| Adam B |
Re: Review Request 40431: Move RoleInfo message out of allocator.proto |
Thu, 17 Dec, 08:50 |
| Adam B |
Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task. |
Thu, 17 Dec, 09:09 |
| Adam B |
Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints |
Thu, 17 Dec, 10:47 |
| Adam B |
Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints |
Thu, 17 Dec, 11:01 |
| Adam B |
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port |
Thu, 17 Dec, 11:11 |
| Adam B |
Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields |
Thu, 17 Dec, 11:21 |
| Adam B |
Re: Review Request 41532: Fixed formatting of C++ style guide. |
Thu, 17 Dec, 22:40 |
| Adam B |
Re: Review Request 40995: Added test cases for role behavior. |
Fri, 18 Dec, 00:57 |
| Adam B |
Re: Review Request 41075: Added support for implicit roles. |
Fri, 18 Dec, 01:24 |
| Adam B |
Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task. |
Fri, 18 Dec, 01:36 |
| Adam B |
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port |
Fri, 18 Dec, 01:40 |
| Adam B |
Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints |
Fri, 18 Dec, 02:01 |
| Adam B |
Re: Review Request 40995: Added test cases for role behavior. |
Fri, 18 Dec, 02:06 |
| Adam B |
Re: Review Request 41408: Updated documentation for implicit roles. |
Fri, 18 Dec, 06:25 |
| Adam B |
Re: Review Request 41225: Added test cases for implicit roles. |
Fri, 18 Dec, 07:37 |
| Adam B |
Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist. |
Fri, 18 Dec, 07:51 |
| Adam B |
Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist. |
Fri, 18 Dec, 07:51 |
| Adam B |
Re: Review Request 41444: Cleaned up Authorizer interface. |
Fri, 18 Dec, 08:42 |
| Adam B |
Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test. |
Fri, 18 Dec, 11:34 |
| Adam B |
Re: Review Request 40429: Report executor exit to framework schedulers. |
Fri, 18 Dec, 12:04 |
| Adam B |
Re: Review Request 41567: Clarified a comment that occurs in several test cases. |
Fri, 18 Dec, 22:21 |
| Adam B |
Re: Review Request 41225: Added test cases for implicit roles. |
Fri, 18 Dec, 22:44 |
| Adam B |
Re: Review Request 41408: Updated documentation for implicit roles. |
Fri, 18 Dec, 23:29 |
| Adam B |
Re: Review Request 41225: Added test cases for implicit roles. |
Fri, 18 Dec, 23:30 |
| Adam B |
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port |
Sat, 19 Dec, 09:50 |
| Adam B |
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port |
Sat, 19 Dec, 10:01 |
| Adam B |
Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields |
Sat, 19 Dec, 10:10 |
| Adam B |
Re: Review Request 41586: Partially enforced commit message guidelines with a hook. |
Thu, 24 Dec, 10:27 |
| Adam B |
Re: Review Request 41584: Added commit message guidelines to docs. |
Thu, 24 Dec, 10:31 |
| Adam B |
Re: Review Request 41444: Cleaned up Authorizer interface. |
Thu, 24 Dec, 10:47 |
| Adam B |
Re: Review Request 41444: Cleaned up Authorizer interface. |
Thu, 24 Dec, 10:55 |
| Adam B |
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port |
Thu, 24 Dec, 11:10 |
| Alex Clemmer |
Re: Review Request 40951: Initial set of source files missing for cmake agent binary. |
Mon, 07 Dec, 22:35 |
| Alex Clemmer |
Re: Review Request 41090: Second iteration of changes for cmake build on linux. |
Wed, 09 Dec, 17:15 |
| Alex Clemmer |
Re: Review Request 41092: Added CMake file for agent executable build. |
Wed, 09 Dec, 17:29 |
| Alex Clemmer |
Re: Review Request 41092: Added CMake file for agent executable build. |
Wed, 09 Dec, 17:31 |
| Alex Clemmer |
Re: Review Request 41090: Second iteration of changes for cmake build on linux. |
Wed, 09 Dec, 17:34 |
| Alex Clemmer |
Re: Review Request 40951: Initial set of source files missing for cmake agent binary. |
Wed, 09 Dec, 17:46 |
| Alex Clemmer |
Re: Review Request 40951: Initial set of source files missing for cmake agent binary. |
Wed, 09 Dec, 17:48 |
| Alex Clemmer |
Re: Review Request 41104: Addes some additional missing source files and put the source files in proper order |
Wed, 09 Dec, 17:50 |
| Alex Clemmer |
Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory |
Wed, 09 Dec, 17:59 |
| Alex Clemmer |
Re: Review Request 41096: Added LFLAGs need for linux cmake build |
Wed, 09 Dec, 18:01 |
| Alex Clemmer |
Re: Review Request 40951: Initial set of source files missing for cmake agent binary. |
Wed, 09 Dec, 22:51 |
| Alex Clemmer |
Re: Review Request 40195: Changed commit hook linting to ignore empty diffs. |
Wed, 09 Dec, 23:01 |
| Alex Clemmer |
Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`. |
Wed, 09 Dec, 23:09 |
| Alex Clemmer |
Re: Review Request 40195: Changed commit hook linting to ignore empty diffs. |
Wed, 09 Dec, 23:09 |
| Alex Clemmer |
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation. |
Thu, 10 Dec, 00:08 |
| Alex Clemmer |
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation. |
Thu, 10 Dec, 01:06 |
| Alex Clemmer |
Re: Review Request 39559: Windows: Implemented `os::mkdtemp`. |
Thu, 10 Dec, 01:14 |
| Alex Clemmer |
Re: Review Request 41090: CMake: Added FindCurl.cmake script to locate curl library. |
Thu, 10 Dec, 01:25 |
| Alex Clemmer |
Re: Review Request 39219: Windows: Added support for `slave/state.cpp`. |
Thu, 10 Dec, 01:27 |
| Alex Clemmer |
Re: Review Request 39219: Windows: Added support for `slave/state.cpp`. |
Thu, 10 Dec, 01:43 |
| Alex Clemmer |
Re: Review Request 39219: Windows: Added support for `slave/state.cpp`. |
Thu, 10 Dec, 01:44 |
| Alex Clemmer |
Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`. |
Thu, 10 Dec, 02:15 |
| Alex Clemmer |
Re: Review Request 41185: CMake: Updated LFLAG for dl library to defined label |
Thu, 10 Dec, 15:57 |
| Alex Clemmer |
Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build |
Thu, 10 Dec, 16:19 |
| Alex Clemmer |
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds. |
Fri, 11 Dec, 18:11 |
| Alex Clemmer |
Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory. |
Fri, 11 Dec, 18:11 |
| Alex Clemmer |
Re: Review Request 39559: Windows: Implemented `os::mkdtemp`. |
Fri, 11 Dec, 18:12 |
| Alex Clemmer |
Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone. |
Fri, 11 Dec, 19:56 |
| Alex Clemmer |
Re: Review Request 39559: Windows: Implemented `os::mkdtemp`. |
Fri, 11 Dec, 19:56 |
| Alex Clemmer |
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds. |
Fri, 11 Dec, 20:00 |
| Alex Clemmer |
Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone. |
Fri, 11 Dec, 20:00 |
| Alex Clemmer |
Re: Review Request 39559: Windows: Implemented `os::mkdtemp`. |
Fri, 11 Dec, 20:03 |
| Alex Clemmer |
Re: Review Request 39559: Windows: Implemented `os::mkdtemp`. |
Fri, 11 Dec, 20:10 |
| Alex Clemmer |
Re: Review Request 39559: Windows: Implemented `os::mkdtemp`. |
Fri, 11 Dec, 20:59 |
| Alex Clemmer |
Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`. |
Sat, 12 Dec, 23:07 |
| Alex Clemmer |
Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`. |
Sat, 12 Dec, 23:08 |
| Alex Clemmer |
Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`. |
Sat, 12 Dec, 23:11 |
| Alex Clemmer |
Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp. |
Tue, 15 Dec, 03:20 |
| Alex Clemmer |
Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp. |
Tue, 15 Dec, 03:38 |
| Alex Clemmer |
Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone. |
Tue, 15 Dec, 19:40 |
| Alex Clemmer |
Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function. |
Tue, 15 Dec, 22:10 |
| Alex Clemmer |
Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function. |
Tue, 15 Dec, 22:13 |
| Alex Clemmer |
Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone. |
Tue, 15 Dec, 23:13 |
| Alex Clemmer |
Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`. |
Tue, 15 Dec, 23:36 |
| Alex Clemmer |
Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`. |
Tue, 15 Dec, 23:37 |
| Alex Clemmer |
Re: Review Request 39889: Windows: Added support for `files/files.hpp`. |
Thu, 17 Dec, 22:11 |
| Alex Clemmer |
Review Request 41604: CMake: Added missing protobuf files to CMake build. |
Mon, 21 Dec, 12:27 |
| Alex Clemmer |
Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems. |
Tue, 22 Dec, 20:15 |
| Alex Clemmer |
Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems. |
Wed, 23 Dec, 02:07 |
| Alex Clemmer |
Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems. |
Wed, 23 Dec, 02:12 |