mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.
Date Thu, 31 Dec 2015 02:41:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review112369
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 163 - 164)
<https://reviews.apache.org/r/41491/#comment172840>

    This fits in one line?



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 166)
<https://reviews.apache.org/r/41491/#comment172841>

    s/v1DockerImageManifest/manifest/
    
    You need to rename the method parameter to `_manifest`



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 173)
<https://reviews.apache.org/r/41491/#comment172843>

    Why Option is needed here? An empty vector means no entry point, right?



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 175)
<https://reviews.apache.org/r/41491/#comment172842>

    You can use `->` operator to avoid `.get()`
    ```
    if (manifest->container_config().entrypoint_size() > 0)
    ```



src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 265 - 269)
<https://reviews.apache.org/r/41491/#comment172844>

    I would use the following indentation
    
    ```
    CHECK(!image.layer_ids().empty());
    
    Try<string> manifest = os::read(
        path::getImageLayerManifestPath(
            flags.docker_store_dir,
            image.layer_ids(image.layer_ids_size() - 1)));
    ```



src/tests/containerizer/provisioner_docker_tests.cpp (line 1614)
<https://reviews.apache.org/r/41491/#comment172846>

    Why change this test?


- Jie Yu


On Dec. 28, 2015, 11:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 11:49 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6

>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981

>   src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98

> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message