mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.
Date Wed, 30 Dec 2015 18:52:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review112337
-----------------------------------------------------------

Ship it!



src/launcher/executor.cpp (line 106)
<https://reviews.apache.org/r/40998/#comment172800>

    use CHECK_EQ? Here and everywhere else.



src/launcher/executor.cpp (line 618)
<https://reviews.apache.org/r/40998/#comment172802>

    s/RUNNING/REGISTERED/?


- Jie Yu


On Dec. 30, 2015, 6:39 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 6:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3851
>     https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa 
> 
> Diff: https://reviews.apache.org/r/40998/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message