mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41715: Support parsing url in libprocess.
Date Wed, 30 Dec 2015 18:25:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41715/#review112328
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/http.cpp (line 169)
<https://reviews.apache.org/r/41715/#comment172790>

    static please since this is local to the file.



3rdparty/libprocess/src/http.cpp (line 212)
<https://reviews.apache.org/r/41715/#comment172791>

    s/addressParts/tokens/


- Jie Yu


On Dec. 28, 2015, 8:23 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41715/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support parsing url in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236

>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc

> 
> Diff: https://reviews.apache.org/r/41715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message