mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.
Date Tue, 29 Dec 2015 23:14:44 GMT


> On Dec. 29, 2015, 7:29 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 807-810
> > <https://reviews.apache.org/r/41167/diff/6/?file=1174158#file1174158line807>
> >
> >     Flying by. We try to avoid huge nested lambda functions. Can you pull the continuation
into `__launch`?
> 
> Joseph Wu wrote:
>     I was under the impression that nested lambdas were preferable to underscore-continuations
whenever the continuation is only called once.
>     
>     (For now, I'll defer making this fix.)

I'm okay with this lambda, it fits on a single screen and is nicely captured here as the continuation.
I agree that really big lambdas should be pulled into functions, but I think this one is pretty
straightforward.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41167/#review112204
-----------------------------------------------------------


On Dec. 22, 2015, 1:21 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41167/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4088
>     https://issues.apache.org/jira/browse/MESOS-4088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes the `MesosContainerizer` to create and initialize the `ContainerLogger`.  
> 
> The `MesosContainerizer` modifies the arguments to `launcher->fork()` (in `::_launch`)
by calling the `ContainerLogger` beforehand.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp ab87cbcc843b471c7931aa38a590896f97be9865

>   src/slave/containerizer/mesos/containerizer.cpp 8242190dffa4d011ee2728a9f0a04d3857767b69

> 
> Diff: https://reviews.apache.org/r/41167/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> This is tested later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message