mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields
Date Tue, 29 Dec 2015 17:55:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review112192
-----------------------------------------------------------

Ship it!


LGTM, just some minor cleanup nits.


src/tests/common/http_tests.cpp (line 103)
<https://reviews.apache.org/r/41381/#comment172515>

    Nit: `const` does not look related to this change and we do not have style guidelines
pertaining to it too. Can we remove all the `const` related changes in this review ?



src/tests/slave_tests.cpp (line 2247)
<https://reviews.apache.org/r/41381/#comment172513>

    Kill this redundant line. You already have specified your intentions of checking if the
Virtual IPs are set in the `DiscoveryInfo` object a few lines before:
    
    ```// Check the virtual IPs are set in the `DiscoveryInfo` object.```



src/tests/slave_tests.cpp (line 2258)
<https://reviews.apache.org/r/41381/#comment172514>

    Kill this line. This made sense when we were having both i.e.
    
    `EXPECT_SOME` and `EXPECT_EQ` instead of having them in one call now.
    
    This alone should suffice:
    ```// Check the ports are set in the `DiscoveryInfo` object.```



src/tests/slave_tests.cpp (line 2259)
<https://reviews.apache.org/r/41381/#comment172516>

    We generally try to make each review a self containing single atomic change. It looks
like that these port related cleanup changes are not related to this review and should have
been part of a separate cleanup patch.
    
    This is fine for now but keep this in mind for future patches.


- Anand Mazumdar


On Dec. 23, 2015, 2:10 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 2:10 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message