mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.
Date Tue, 29 Dec 2015 03:11:13 GMT


> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 221
> > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line221>
> >
> >     "else" case?

Nothing needs to be done for the `else` case. These env variables **might** be set by the
agent when framework checkpointing is enabled. For more info see how the old executor library
checks it:
https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L690


> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 232
> > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line232>
> >
> >     "else" case?

Ditto as above


> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 266
> > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line266>
> >
> >     Why not use universal initialization ({....})?

`Request` struct has a lot of fields all of which are not used by us. Hence, univeral initialization
is not possible. 
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/http.hpp#L224


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review112114
-----------------------------------------------------------


On Dec. 29, 2015, 12:11 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 12:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
>     https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces the implementation for the executor library. 
> 
> This uses the new HTTP Connection interface to ensure calls are properly pipelined.
> 
> `connected` -> Callback invoked when a TCP connection is established with the agent.
> `disconnected` -> When the TCP connection is interrupted possibly due to an agent
restart.
> `received` -> When the executor receives events from the agent upon subscribing.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message