mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 41715: Support parsing url in libprocess.
Date Mon, 28 Dec 2015 20:05:56 GMT


> On Dec. 27, 2015, 2:56 a.m., Jojy Varghese wrote:
> > 3rdparty/libprocess/src/http.cpp, line 190
> > <https://reviews.apache.org/r/41715/diff/2/?file=1176450#file1176450line190>
> >
> >     Can we avoid using magic numbers ('3' here)?

It's paired with the magic string '://' :) I'm not sure what I would even call this if we
move it out.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41715/#review111918
-----------------------------------------------------------


On Dec. 26, 2015, 8:24 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41715/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 8:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support parsing url in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236

>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc

> 
> Diff: https://reviews.apache.org/r/41715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message