-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/#review111984
-----------------------------------------------------------
Do you think it makes sense to add some configure checks?
3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp (lines 21 - 22)
<https://reviews.apache.org/r/41461/#comment172296>
Do you want to reference MESOS-3993? Maybe update the ticket as well, once this lands.
3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp (lines 33 - 34)
<https://reviews.apache.org/r/41461/#comment172298>
Let's make a note that `std::invoke()`, which is c++17 AFAIK, is supported by msvc 2015
and it's not in <functional>.
3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp (line 41)
<https://reviews.apache.org/r/41461/#comment172314>
`int` is dummy here, right? Mind writing a comment about it?
- Alexander Rukletsov
On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41461/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 3:42 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
>
>
> Repository: mesos
>
>
> Description
> -------
>
> VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so `result_of` must
be replaced with `decltype(invoke)`.
>
> Here, we implement SFINAE `result_of` in `stout`.
>
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe
> 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41461/diff/
>
>
> Testing
> -------
>
> `make check` on OS X, compiled on Windows.
>
>
> Thanks,
>
> Michael Park
>
>
|