mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 41731: Removed docker puller flag.
Date Mon, 28 Dec 2015 17:22:07 GMT


> On Dec. 27, 2015, 5:42 a.m., Gilbert Song wrote:
> > src/slave/flags.cpp, lines 145-146
> > <https://reviews.apache.org/r/41731/diff/1/?file=1176474#file1176474line145>
> >
> >     Could we use pure directory only for local puller?
> >     
> >     Instead of adding `file://` to the flag & strings::remove it, because some
users may easily neglect a slash for this pattern.
> 
> Timothy Chen wrote:
>     We need to differentiate based on the flag's value to be local or registry as we
consolidated a bunch of flags down to a single one now.
> 
> Gilbert Song wrote:
>     Is it possible to select local or registry by:
>     
>     `if (!strings::startsWith(imagesUrl, "https://"))`
>     
>     Not 100% sure it is safe enough. If no, we could drop this issue. However, we may
still consider user with `--docker_image=file:///tmp/mesos/images/docker` VS `--docker_image=/tmp/mesos/images/docker`
in the future.

That's just not possible if we stick with this configuration.
Btw Jie I just realize that the downside of consolidating flags like this is that, users that
want to use the docker registry will then have to specify the docker registry URL themselves
everytime now, which we used to have a default value for a seperate flag. To me that's a pretty
bad experience as well. What did you guys conclude last time when you guys discussed about
this?


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41731/#review111921
-----------------------------------------------------------


On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41731/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed docker puller flag.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp f71b572a32443a6715acb4d3541aec60e0437b30

>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp dd17acf6a6e5c306029198dbb2a7e2d059f87f75

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7cdb15b9529eab82867b3470a016bb8ad09ff250

>   src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98

> 
> Diff: https://reviews.apache.org/r/41731/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message