mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mp...@apache.org>
Subject Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.
Date Mon, 28 Dec 2015 15:42:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 3:42 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-4228
    https://issues.apache.org/jira/browse/MESOS-4228


Repository: mesos


Description
-------

The Standard (C++11 through 17) does not require `std::bind`'s function call operator to SFINAE,
and VS 2015's doesn't. `std::is_bind_expression` can be used to manually reroute bind expressions
to the 1-arg overload, where (conveniently) the argument will be ignored if necessary.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs
-----

  3rdparty/libprocess/include/process/future.hpp c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c


Diff: https://reviews.apache.org/r/41460/diff/


Testing
-------

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message