mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 41661: Added documentation for API versioning.
Date Sun, 27 Dec 2015 21:08:41 GMT


> On Dec. 27, 2015, 3:25 a.m., Jojy Varghese wrote:
> > docs/versioning.md, line 7
> > <https://reviews.apache.org/r/41661/diff/3/?file=1174978#file1174978line7>
> >
> >     ephasize 0.24.0 (in quotes). Same in other places.

I tried to be consistent to other docs and they did not have quotes.

e.g:
http://mesos.apache.org/documentation/latest/ssl/
http://mesos.apache.org/documentation/latest/framework-rate-limiting/
http://mesos.apache.org/documentation/latest/scheduler-http-api/


> On Dec. 27, 2015, 3:25 a.m., Jojy Varghese wrote:
> > docs/versioning.md, line 62
> > <https://reviews.apache.org/r/41661/diff/3/?file=1174978#file1174978line62>
> >
> >     This section could use some formatting. 
> >     
> >     Also, would be useful to take the reader through a complete example covering
a message's external and internal path.

Can you elaborate a bit more on what did you mean by:

```This section could use some formatting.```


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111919
-----------------------------------------------------------


On Dec. 23, 2015, 2:09 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 2:09 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
>     https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds documentation on how Mesos does API versioning. It also has a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -----
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message