-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41731/#review111924
-----------------------------------------------------------
src/slave/flags.cpp
<https://reviews.apache.org/r/41731/#comment172217>
When changing these flags we should also update the documentation: http://mesos.apache.org/documentation/latest/configuration/
src/slave/flags.cpp (line 136)
<https://reviews.apache.org/r/41731/#comment172216>
Do I understand correctly that we change the default from "Pull from docker registry"
to "pull from a local file location"? Wouldn't that impact users experimenting with Mesos?
If this is not the case feel to drop.
- Joerg Schad
On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41731/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 12:22 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed docker puller flag.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp f71b572a32443a6715acb4d3541aec60e0437b30
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp dd17acf6a6e5c306029198dbb2a7e2d059f87f75
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7cdb15b9529eab82867b3470a016bb8ad09ff250
> src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9
> src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806
> src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98
>
> Diff: https://reviews.apache.org/r/41731/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
|