mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41444: Cleaned up Authorizer interface.
Date Thu, 24 Dec 2015 10:55:13 GMT


> On Dec. 18, 2015, 12:42 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.hpp, line 144
> > <https://reviews.apache.org/r/41444/diff/1/?file=1166378#file1166378line144>
> >
> >     s/reserve particular resources/reserve resources/ since the only values currently
allowed for `resources` are ANY or NONE.
> 
> Alexander Rukletsov wrote:
>     I'd say, that's an implementation detail of `LocalAuthorizer`; AFAIK, we do not enforce
it anywhere. I'm fine with leaving a `NOTE` though. What do you think?

That's fine. Dropping these issues.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41444/#review111142
-----------------------------------------------------------


On Dec. 22, 2015, 5:53 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41444/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 5:53 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, and Till
Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extract a repetitive part of the function comments into a class comment. Added backticks,
quotes when necessary, formatted comments to avoid jaggedness.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
>   src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c 
> 
> Diff: https://reviews.apache.org/r/41444/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message