mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avinash sridharan" <avin...@mesosphere.io>
Subject Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port
Date Tue, 22 Dec 2015 22:05:15 GMT


> On Dec. 19, 2015, 10:01 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 1576-1577
> > <https://reviews.apache.org/r/41380/diff/8/?file=1172691#file1172691line1576>
> >
> >     Do we expect to add more fields to the Vip message later?
> >     If not, why don't we just add a `repeated string vips` to DiscoveryInfo?
> >     If so, what do you think we'd add? Maybe a service name, in case the same task
has multiple services exposed on different vips?
> 
> Anand Mazumdar wrote:
>     hmm ... Since a VIP is just a virtual IP address. Why not use the existing `Address`
message and just add the following to `DiscoveryInfo`:
>     
>     `repeated Address vips;`
> 
> Avinash sridharan wrote:
>     This is the Address message :message Address {
>       // May contain a hostname, IP address, or both.
>       optional string hostname = 1;
>       optional string ip = 2;
>     
>       required int32 port = 3;
>     }
>     
>     The problem with using this is that port is a required field in the Address type
(a bit odd). In case of virtual IP's they need to be explicitly IP and port is mapping that
is provided separately (message Port). So don't think will make sense to use it in this context
?
> 
> Avinash sridharan wrote:
>     I am just thinking that given this is a virtual endpoint there might be other metadata
(labels is what comes to mind right now) that might be associated with this in the future.
 Similar to the message Port. As you pointed out named Vips is another option.

Have added a new message type IPAddress which is in the top-level namespace. Also, after talking
to Anand have kept the enums in the IPAddress field as protocol, since renaming the field
will cause another set of churn that is better to avoid at this stage.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review111369
-----------------------------------------------------------


On Dec. 22, 2015, 10:03 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 10:03 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
>     https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> -------
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message