mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41513: Cleaned up STL I/O includes.
Date Tue, 22 Dec 2015 17:59:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41513/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 5:59 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park.


Changes
-------

Rebased & wrapped description.


Bugs: MESOS-4183
    https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description (updated)
-------

Move `operator<<` definitions to ".cpp" files and include `<iosfwd>`
in ".hpp"s.


Diffs (updated)
-----

  src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 
  src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de 
  src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed 
  src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e 
  src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e 
  src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 
  src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b 

Diff: https://reviews.apache.org/r/41513/diff/


Testing
-------

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message