mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.
Date Tue, 22 Dec 2015 17:56:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41512/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 5:56 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park.


Changes
-------

Rebased & wrapped description.


Bugs: MESOS-4183
    https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description (updated)
-------

Where possible move `operator<<` definitions and functions using streams
to ".cpp" files and include <iosfwd> in ".hpp"s. Also remove unused I/O
includes, add necessary includes, clean up `std::` prefixes.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.hpp 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
  include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d 
  include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 
  src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa 
  src/common/http.cpp 2ecb78c582325c3e5141a9946516d6c9e8d7106f 

Diff: https://reviews.apache.org/r/41512/diff/


Testing
-------

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message