mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.
Date Tue, 22 Dec 2015 17:51:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41509/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 5:51 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park.


Changes
-------

Rebased.


Bugs: MESOS-4183
    https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description
-------

Where possible move `operator<<` definitions and functions using streams to ".cpp" files
and include `<iosfwd>` in ".hpp"s. Also remove unused I/O includes and clean up `std::`
prefixes.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/address.hpp 79429e904546ebeb993663efb9bd9e212c1dbd63

  3rdparty/libprocess/include/process/future.hpp 817fca2ba5352a2c1cea1cb6cf6ecc49821215e4

  3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236 
  3rdparty/libprocess/include/process/pid.hpp b22c160ad0051ea1dac733a39a9f833719dbcb58 
  3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
  3rdparty/libprocess/src/pid.cpp 1a9cbd1eec6aefbd9a40113ae0f4475a90011b85 

Diff: https://reviews.apache.org/r/41509/diff/


Testing
-------

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message