mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39614: Quota: Added Status Validation Tests.
Date Tue, 22 Dec 2015 12:15:59 GMT


> On Dec. 22, 2015, 10:43 a.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 578
> > <https://reviews.apache.org/r/39614/diff/7/?file=1174450#file1174450line578>
> >
> >     The ReviewBot is failing because `quotaResources` must be flattened.
> >     
> >     Also, why do you use `ASSERT_*` instead of `EXPECT_*` which are used throughout
the test?

I use ASSERT_* if the following part of the test relies (hard) on the outcome, e.g. checking
array sizes or calling get() on a Try.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review111597
-----------------------------------------------------------


On Dec. 22, 2015, 10:19 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 10:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4218
>     https://issues.apache.org/jira/browse/MESOS-4218
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message