mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39614: Quota: Added Status Validation Tests.
Date Tue, 22 Dec 2015 09:31:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review111508
-----------------------------------------------------------


Looks good. Some high-level comments:
- You use `const` inconsistently. We have different opinions in the community about marking
local variables `const`, I personally would like to see them more often. However, let's stay
consistent throughout the test/function/class.
- I think we can easily merge two tests into one: query quota status; add an agent, set quota
and query again; remove quota and query one more time. You can use scopes to separate these
stages from one another like you did in `SetInvalidResourceInfos`. You can go even further
and add status checks to existing tests, but I would prefer to have a separate test for status
endpoint. I leave this decision to you and your shepherd.


src/tests/master_quota_tests.cpp (lines 492 - 493)
<https://reviews.apache.org/r/39614/#comment171710>

    s/no quota set/no quotas set
    s/"against /quota."/"."



src/tests/master_quota_tests.cpp (line 517)
<https://reviews.apache.org/r/39614/#comment171805>

    Why `parse` is marked `const` and `array` isn't?



src/tests/master_quota_tests.cpp (line 540)
<https://reviews.apache.org/r/39614/#comment171806>

    Since there is just one agent, no need to enumerate it.


- Alexander Rukletsov


On Dec. 21, 2015, 5:16 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 5:16 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4218
>     https://issues.apache.org/jira/browse/MESOS-4218
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message