mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.
Date Tue, 22 Dec 2015 01:35:34 GMT


> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 226
> > <https://reviews.apache.org/r/41378/diff/1/?file=1164065#file1164065line226>
> >
> >     If we expect NULL to be a valid option we should make it an Option.
> 
> Joseph Wu wrote:
>     NULL is not a valid argument.  But for some of these tests, I thought it would unnecessarily
bloat the test code to create an unused `ContainerLogger`.

Note: the latest diff removed this change.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review110398
-----------------------------------------------------------


On Dec. 21, 2015, 5:35 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 5:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4137
>     https://issues.apache.org/jira/browse/MESOS-4137
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp a43e355405b37443601c0993d36821c50056c24f

>   src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187 
> 
> Diff: https://reviews.apache.org/r/41378/diff/
> 
> 
> Testing
> -------
> 
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message