mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.
Date Tue, 22 Dec 2015 01:32:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41294/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 5:32 p.m.)


Review request for mesos, Benjamin Hindman, haosdent huang, and Artem Harutyunyan.


Changes
-------

Remove `ContainerLogger` injection from the `Docker` class.


Bugs: MESOS-4137
    https://issues.apache.org/jira/browse/MESOS-4137


Repository: mesos


Description
-------

The `DockerContainerizer` creates and initializes its own `ContainerLogger` and passes it
into the `Docker` wrapper.

The `ContainerLogger` is used before launching executors, in two two call sites depending
on whether the agent is running in a container or not.


Diffs (updated)
-----

  src/docker/docker.hpp c769372090513b702daa2def265aedf536565f96 
  src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e 
  src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 

Diff: https://reviews.apache.org/r/41294/diff/


Testing
-------

Tests will be modified and run later in the review chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message