mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.
Date Tue, 22 Dec 2015 01:21:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41167/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 5:21 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Fix ambiguity in ternary conditional.


Bugs: MESOS-4088
    https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description
-------

Changes the `MesosContainerizer` to create and initialize the `ContainerLogger`.  

The `MesosContainerizer` modifies the arguments to `launcher->fork()` (in `::_launch`)
by calling the `ContainerLogger` beforehand.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.hpp ab87cbcc843b471c7931aa38a590896f97be9865

  src/slave/containerizer/mesos/containerizer.cpp 8242190dffa4d011ee2728a9f0a04d3857767b69


Diff: https://reviews.apache.org/r/41167/diff/


Testing
-------

make

This is tested later in the review chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message