mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.
Date Mon, 21 Dec 2015 14:15:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111462
-----------------------------------------------------------



src/master/quota_handler.cpp (line 60)
<https://reviews.apache.org/r/41603/#comment171669>

    Could you add a blank line between using and namespace? THX


- Joerg Schad


On Dec. 21, 2015, 1:30 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 1:30 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3960
>     https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/41603/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message