mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avinash sridharan" <avin...@mesosphere.io>
Subject Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields
Date Sun, 20 Dec 2015 05:26:40 GMT


> On Dec. 19, 2015, 10:10 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 2248-2253
> > <https://reviews.apache.org/r/41381/diff/8/?file=1172696#file1172696line2248>
> >
> >     EXPECT_SOME_EQ here too. Since this was your own test that we just committed,
let's fix it ourselves now.

Ok. will do.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111370
-----------------------------------------------------------


On Dec. 20, 2015, 1:56 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2015, 1:56 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message