mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port
Date Sat, 19 Dec 2015 10:01:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review111369
-----------------------------------------------------------


Please rename `Vip` back, or go with `VIP`. Or get rid of that message altogether if it makes
sense.


include/mesos/mesos.proto (lines 1576 - 1577)
<https://reviews.apache.org/r/41380/#comment171531>

    Do we expect to add more fields to the Vip message later?
    If not, why don't we just add a `repeated string vips` to DiscoveryInfo?
    If so, what do you think we'd add? Maybe a service name, in case the same task has multiple
services exposed on different vips?


- Adam B


On Dec. 18, 2015, 11:16 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 11:16 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
>     https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> -------
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message