mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.
Date Fri, 18 Dec 2015 23:23:44 GMT


> On Dec. 18, 2015, 11:21 p.m., Anand Mazumdar wrote:
> > src/common/http.cpp, line 299
> > <https://reviews.apache.org/r/41423/diff/5/?file=1171713#file1171713line299>
> >
> >     Shouldn't this be:
> >     
> >     ```
> >     object.values["container"] = std::move(task.container());
> >     ```

my bad: object.values["container"] = std::move(model(task.container()));

Wondering , still though,  why aren't you using the automated protobuf to json converters
and get rid of the `model` code ?


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41423/#review111307
-----------------------------------------------------------


On Dec. 18, 2015, 11:12 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41423/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 11:12 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4064
>     https://issues.apache.org/jira/browse/MESOS-4064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed partial contents of ContainerInfo through the state endpoint.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 
>   src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c

> 
> Diff: https://reviews.apache.org/r/41423/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message