mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.
Date Fri, 18 Dec 2015 23:12:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40255/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 11:12 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
-------

Addressed comments.


Bugs: MESOS-3065
    https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
-------

Added framework authorization for persistent volumes.


Diffs (updated)
-----

  src/master/master.cpp 470b542729b01f41fc6a2e601a7a6c3d0c5353d5 
  src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486 

Diff: https://reviews.apache.org/r/40255/diff/


Testing
-------

This is the fifth in a chain of 7 patches. New tests were added to `persistent_volume_tests.cpp`
in order to test a framework attempting both successful and failed authorizations for `CREATE`
and `DESTROY` offer operations. `make check` was used to test after all patches were applied.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message