mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 41560: Change Docker::run to take Subprocess::IO instead of Option<string>
Date Fri, 18 Dec 2015 21:44:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41560/#review111278
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41560]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 18, 2015, 7:06 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41560/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joris Van Remoortere,
and Timothy Chen.
> 
> 
> Bugs: MESOS-4137
>     https://issues.apache.org/jira/browse/MESOS-4137
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes the FDs used by the `mesos-docker-executor` to inherit rather than open
anew.
> 
> In the `mesos-docker-executor`, we originally passed the log file path (i.e. `path::join(sandboxDirectory,
"stdout")`) as an argument to `Docker::run`.  In the executor's context, the log file is already
open as `STDOUT_FILENO`.
> 
> By inheriting the FD, the docker containerizer's logging-code will path mirrors that
of the mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
>   src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 
>   src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
>   src/tests/mesos.hpp 1c6acabab9d189a6d3cc8d63359053fd230377b8 
> 
> Diff: https://reviews.apache.org/r/41560/diff/
> 
> 
> Testing
> -------
> 
> make check (Centos7)
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_Logs*"
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message