mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.
Date Fri, 18 Dec 2015 19:04:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/#review111229
-----------------------------------------------------------

Ship it!



src/tests/containerizer/provisioner_docker_tests.cpp (line 302)
<https://reviews.apache.org/r/41490/#comment171322>

    2 lines apart.



src/tests/containerizer/provisioner_docker_tests.cpp (line 386)
<https://reviews.apache.org/r/41490/#comment171323>

    s/v1DockerImageManifest/manifest/


- Jie Yu


On Dec. 18, 2015, 6:58 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41490/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 6:58 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4186
>     https://issues.apache.org/jira/browse/MESOS-4186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provisioner: Added test case for docker v1 manifest serialization.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2

> 
> Diff: https://reviews.apache.org/r/41490/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message