mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40903: Ported approximated Option<double> CPU resource number comparison to v1 and improved the check expression for this.
Date Fri, 18 Dec 2015 09:31:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40903/#review111154
-----------------------------------------------------------



src/v1/resources.cpp (line 39)
<https://reviews.apache.org/r/40903/#comment171178>

    Unnecessary blank line.



src/v1/resources.cpp (line 49)
<https://reviews.apache.org/r/40903/#comment171179>

    I'm not sure that's the way we do it, but I would prefer to remove this using and write
`mesos::internal::master::MIN_CPUS` explicitly to increase the pain and motivate ourselves
remove that dependency ASAP.
    
    Also in "src/common/resources.cpp"


- Alexander Rukletsov


On Dec. 3, 2015, 11:09 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40903/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, Ben Mahler, Greg Mann,
Klaus Ma, Mandeep Chadha, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Copied the changes from common/resources.cpp in r40767 to v1/reources.cpp, also addressing
BenM's post-review. Thanks to @greggomann for spotting this.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 
>   src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717 
> 
> Diff: https://reviews.apache.org/r/40903/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message