mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avinash sridharan" <avin...@mesosphere.io>
Subject Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints
Date Thu, 17 Dec 2015 22:40:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 10:40 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Bugs: MESOS-3962
    https://issues.apache.org/jira/browse/MESOS-3962


Repository: mesos


Description
-------

Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages
to HTTP endpoints


Diffs (updated)
-----

  src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239 
  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41188/diff/


Testing
-------

make check.
Added Unit tests to verify setting of DiscoveryInfo in state.json in slave. 
Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf
is converted to JSON objects.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message