mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.
Date Thu, 17 Dec 2015 21:14:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/#review111059
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Dec. 17, 2015, 12:20 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40168/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4178
>     https://issues.apache.org/jira/browse/MESOS-4178
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
>   src/authorizer/local/authorizer.hpp 965658b53d21734a2dbf3713d02d44d728fd6cca 
>   src/authorizer/local/authorizer.cpp 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
>   src/tests/authorization_tests.cpp b5fb3c30e4c53bf3bf081c2a9a30a327f2c7c880 
>   src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
> 
> Diff: https://reviews.apache.org/r/40168/diff/
> 
> 
> Testing
> -------
> 
> This is the third in a chain of 7 patches. New tests were added to `authorization_tests.cpp`
in order to test the authorizer's handling of both successful and failed authorization attempts
using `ACL::CreateVolume` and `ACL::DestroyVolume`. `make check` was used to test after all
patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message