mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.
Date Thu, 17 Dec 2015 10:21:07 GMT


> On Dec. 17, 2015, 10:20 a.m., Joerg Schad wrote:
> > include/mesos/authorizer/authorizer.hpp, lines 177-180
> > <https://reviews.apache.org/r/40346/diff/5/?file=1164652#file1164652line177>
> >
> >     , otherwise ...

(Consistent with the other comments)


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/#review110928
-----------------------------------------------------------


On Dec. 15, 2015, 11:06 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40346/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:06 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere,
and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Implemented authorization of quota requests in the authorizer.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
>   src/authorizer/local/authorizer.hpp 965658b53d21734a2dbf3713d02d44d728fd6cca 
>   src/authorizer/local/authorizer.cpp 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
>   src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
> 
> Diff: https://reviews.apache.org/r/40346/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message