mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <>
Subject Re: Review Request 41244: Using 'git rev-parse --git-dir' in
Date Thu, 17 Dec 2015 03:07:40 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 17, 2015, 3:07 a.m.)

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.

Bugs: MESOS-4125

Repository: mesos


The script has similar problems to the bootstrap script
in assuming that .git is a folder in the top-level directory of the git
repo.  This may not be true when mesos is included as a submodule in
another project. Use 'git rev-parse --git-dir' instead.


  support/ 170be83aa6dca6e8175292169d78e8f7915f7e6e 


Testing (updated)

I have been posting all of my reviews with this script since first creating this commit. Tested
both in an environment with and without mesos embedded as a submodule inside another git repository.


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message