mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 41371: Fixed getting started instructions for centos 7.1.
Date Thu, 17 Dec 2015 01:43:32 GMT


> On Dec. 16, 2015, 11:59 p.m., Jojy Varghese wrote:
> > docs/getting-started.md, line 127
> > <https://reviews.apache.org/r/41371/diff/2/?file=1165243#file1165243line127>
> >
> >     I would enclose libserf-1 i backticks.
> 
> Kevin Klues wrote:
>     Again, this is contained in a code block, so backticks don't do anything special.
I'd rather just add them in regular ticks.

docs/markdown-style-guide.md says "We use single backticks to highlight individual words in
a sentence such as certain identifiers". docs/fetcher.md is a good example of this.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41371/#review110801
-----------------------------------------------------------


On Dec. 17, 2015, 1:18 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41371/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 1:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Jojy Varghese, and Neil Conway.
> 
> 
> Bugs: MESOS-3842
>     https://issues.apache.org/jira/browse/MESOS-3842
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current instructions are broken for installing the development tools
> on centos 7.1 after updating the WANdisco SVN repo file. Specifically,
> the updated svn installation requires libserf-1, which is not part of
> the base yum repository.  We need to install the epel repository to get
> access to libserf-1.
> 
> As part of this, I also update the instructions to install
> java-1.8.0-openjdk-devel instead of java-1.7.0-openjdk-devel. This is
> necessary because our instructions have us installing apache-maven
> BEFORE installing java-1.7.0-openjdk-devel. As such, installing maven
> installs the default jre from the base repository (java-1.8.0-openjdk)
> as one of its dependencies. This causes problems with finding the proper
> java.home in our mesos/configure script because of the mismatch between
> the most up to date jre (1.8.0) and the most up to date development
> tools (1.7.0). Alternative solutions to resolve this problem probably
> exist (i.e. move our dependence on maven until AFTER our installation of
> java-1.7.0-openjdk-devel), but this would likely break if running on a
> system that already had the 1.8.0 jre installed for other purposes. Best
> to just update to the newwest default version of the java development
> tools.
> 
> Review: https://reviews.apache.org/r/41371
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message