mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.
Date Thu, 17 Dec 2015 01:23:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/#review110827
-----------------------------------------------------------

Ship it!



src/slave/container_loggers/sandbox.hpp (line 44)
<https://reviews.apache.org/r/41003/#comment170825>

    Can we leave a comment of what this provides? And that it's the default?



src/slave/container_loggers/sandbox.cpp (line 55)
<https://reviews.apache.org/r/41003/#comment170836>

    Is this comment useful? Is there something else here you want to capture?



src/slave/container_loggers/sandbox.cpp (line 72)
<https://reviews.apache.org/r/41003/#comment170832>

    Can we put a newline before this? Or:
    
    info.environment = environment.get({});


- Benjamin Hindman


On Dec. 15, 2015, 8:39 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41003/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 8:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4087
>     https://issues.apache.org/jira/browse/MESOS-4087
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This implementation mirrors how executor/task stdout/stderr is currently saved to plain
files.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/sandbox.hpp PRE-CREATION 
>   src/slave/container_loggers/sandbox.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41003/diff/
> 
> 
> Testing
> -------
> 
> This is added to the Makefile later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message