mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 40431: Move RoleInfo message out of allocator.proto
Date Wed, 16 Dec 2015 22:59:33 GMT


> On Nov. 24, 2015, 6:48 p.m., Klaus Ma wrote:
> > include/mesos/role/role.proto, line 38
> > <https://reviews.apache.org/r/40431/diff/7/?file=1138459#file1138459line38>
> >
> >     I'm thinke whether we need to enhance weight to `int`. Any case that we has
to use `double` as weight? If we want to control the scope, TODO is OK.
> 
> Yongqiao Wang wrote:
>     In mesos, weight can be any value greater than -1, I think it's make sence. It does
not need to change it's type to int if there is no specified requirement.

Current share is divided by weight, then compared against other roles' share, so we're already
going to be comparing floating point numbers. We don't directly compare weights or generate
units based on these values, so I don't think floating point imprecision is a concern.
Besides, since the default weight is 1.0, adding a new low-priority role with lower-than-average
weight is impossible without using floating point or simultaneously increasing all other weights
proportionately. It's valuable to be able to set a 0.5 weight.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/#review107903
-----------------------------------------------------------


On Dec. 7, 2015, 9:20 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40431/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 9:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3944
>     https://issues.apache.org/jira/browse/MESOS-3944
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently role protobuf is defined in allocator.proto due to only the traditional DRF
allocator uses roles as it’s first level of hierarchy, I think we should move it out and
define it in a separated file as quota had in dynamic roles project, because role protobuf
will also be used by master to persist.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c 
>   include/mesos/role/role.hpp PRE-CREATION 
>   include/mesos/role/role.proto PRE-CREATION 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
>   src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 
>   src/master/allocator/mesos/allocator.hpp 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 99c742906874c30c39c159e58a65277ade3c07fd

>   src/master/allocator/mesos/hierarchical.cpp 5da825a1d578a9ee40b4985378fddb3c5fb3b416

>   src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
>   src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c 
>   src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
>   src/tests/hierarchical_allocator_tests.cpp fb214a829a57529d3f5c49730ae9733f53e622ca

> 
> Diff: https://reviews.apache.org/r/40431/diff/
> 
> 
> Testing
> -------
> 
> 1. Make Check successfully;
> 
> 2. $ curl http://9.110.48.168:5050/roles
> {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message