mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.
Date Wed, 16 Dec 2015 14:36:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review110656
-----------------------------------------------------------



src/master/master.cpp (lines 2870 - 2871)
<https://reviews.apache.org/r/40169/#comment170692>

    Looks like a copy-paste-induced typo slipped in : ), I believe you mean "volume is created".


- Alexander Rukletsov


On Dec. 15, 2015, 9:18 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 9:18 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4179
>     https://issues.apache.org/jira/browse/MESOS-4179
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
>   src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c 
> 
> Diff: https://reviews.apache.org/r/40169/diff/
> 
> 
> Testing
> -------
> 
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches
were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message