mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41414: Exit nicely when a pid gets reused
Date Tue, 15 Dec 2015 23:41:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41414/#review110580
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 2255)
<https://reviews.apache.org/r/41414/#comment170526>

    I wouldn't mention 'eth0' in the error message because it's not useful.


- Jie Yu


On Dec. 15, 2015, 11:38 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41414/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:38 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We saw the following assertion failure when PID got reused before the container got cleaned
up.
> 
> 
> F1110 20:30:17.903465 21542 port_mapping.cpp:2241] Check failed: createQdisc.get() 
> 
> *** Check failure stack trace: ***
> 
>     @     0x7f1d5598c82d  google::LogMessage::Fail()
>     @     0x7f1d5598e674  google::LogMessage::SendToLog()
>     @     0x7f1d5598c41c  google::LogMessage::Flush()
>     @     0x7f1d5598ef69  google::LogMessageFatal::~LogMessageFatal()
>     @     0x7f1d55674621  mesos::internal::slave::PortMappingIsolatorProcess::isolate()
>     @     0x7f1d5547f286  _ZNSt17_Function_handlerIFvPN7process11ProcessBaseEEZNS0_8dispatchI7NothingN5mesos8internal5slave20MesosIsolatorProcessERKNS6_11ContainerIDEiSA_iEENS0_6F
> utureIT_EERKNS0_3PIDIT0_EEMSH_FSF_T1_T2_ET3_T4_EUlS2_E_E9_M_invokeERKSt9_Any_dataS2_
>     @     0x7f1d5593db91  process::ProcessManager::resume()
>     @     0x7f1d5593de97  _ZNSt6thread5_ImplISt12_Bind_simpleIFSt5_BindIFZN7process14ProcessManager12init_threadsEvEUlRKSt11atomic_boolE_St17reference_wrapperIS6_EEEvEEE6_M_runEv
>     @     0x7f1d55a4edf0  execute_native_thread_routine
>     @     0x7f1d545c883d  start_thread
>     @     0x7f1d5403dfdd  clone
> /usr/local/bin/mesos-slave.sh: line 104: 21519 Aborted                 (core dumped)
$debug /usr/local/sbin/mesos-slave "${MESOS_FLAGS[@]}"
> Slave Exit Status: 134
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 49e215ba3502bba029956fedfc8bd828c3b4a028

> 
> Diff: https://reviews.apache.org/r/41414/diff/
> 
> 
> Testing
> -------
> 
> Run recovery tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message