mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.
Date Tue, 15 Dec 2015 23:37:11 GMT


> On Dec. 15, 2015, 6:57 p.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp, line
37
> > <https://reviews.apache.org/r/39888/diff/2/?file=1126011#file1126011line37>
> >
> >     Returning NULL without setting errno is probably not a good idea. We might want
to standardize on '0' for group/user IDs on Windows.

Per our conversation, you proposed we set `ENOSYS` to indicate that the function is not implemented,
and I thought that's great, so that's what we did. I also added a comment about that.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110536
-----------------------------------------------------------


On Dec. 15, 2015, 11:36 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am d1ef6f0df82e83d8e0d38f7b8986403702519a7d

>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 43c85f50958dd9a7ee2ad7c32565585560486c69

> 
> Diff: https://reviews.apache.org/r/39888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message