mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout test duration.
Date Tue, 15 Dec 2015 17:46:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40956/#review110515
-----------------------------------------------------------

Ship it!


Ship It!


src/tests/health_check_tests.cpp (line 866)
<https://reviews.apache.org/r/40956/#comment170436>

    Could you also change `local` to true here? So that we could get more details about healthy
check process when next failure.


- haosdent huang


On Dec. 4, 2015, 6:24 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40956/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 6:24 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reduced HealthCheckTest.CheckCommandTimeout test duration to 1.5 seconds locally.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 
> 
> Diff: https://reviews.apache.org/r/40956/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message