mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Naparu" <alex.nap...@outlook.com>
Subject Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.
Date Tue, 15 Dec 2015 04:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110392
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 79)
<https://reviews.apache.org/r/39019/#comment170225>

    Consider using a smart pointer instead. Same below.



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 215)
<https://reviews.apache.org/r/39019/#comment170231>

    This is copied here, but malloc'd elsewhere. Is that safe?



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 230)
<https://reviews.apache.org/r/39019/#comment170237>

    Consider using safe versions of string functions



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 74)
<https://reviews.apache.org/r/39019/#comment170220>

    Might want to add this as a reference too: https://msdn.microsoft.com/en-us/library/930f87yf.aspx
    
    MAX_PATH is horribly obsolete, we might want to consider checking whether we're running
on NTFS for all FS-related ops. That will be true in the vast majority of cases these days.


- Alex Naparu


On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
>     https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027

> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message