mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.
Date Tue, 15 Dec 2015 01:36:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review110363
-----------------------------------------------------------



include/mesos/executor/executor.proto (line 89)
<https://reviews.apache.org/r/41275/#comment170174>

    s/an executor/the executor/
    
    Nit: Oxford comma?
    
    Ditto below.



include/mesos/executor/executor.proto (line 93)
<https://reviews.apache.org/r/41275/#comment170175>

    Do you want to use `TimeInfo` (integer) here instead of a `double`?


- Joseph Wu


On Dec. 11, 2015, 3:51 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 3:51 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
>     https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces a field `grace_period_seconds` that specifies the time an agent
would wait for the executor to terminate before forcefully destroying the container.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4 
>   include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231 
> 
> Diff: https://reviews.apache.org/r/41275/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message