mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.
Date Tue, 15 Dec 2015 00:28:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/#review110346
-----------------------------------------------------------



3rdparty/libprocess/include/process/owned.hpp (lines 122 - 127)
<https://reviews.apache.org/r/39851/#comment170158>

    This is a really long `NOTE:` considering the issue.



3rdparty/libprocess/include/process/owned.hpp (line 128)
<https://reviews.apache.org/r/39851/#comment170159>

    let's use a static cast?


- Joris Van Remoortere


On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39851/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 9:14 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: fixed ambiguousity error in `process/owned.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/owned.hpp 1b41477d555ce567c58033f8993dc2ae0ac80a05

> 
> Diff: https://reviews.apache.org/r/39851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message