mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41166: Logger Module: Explicitly disallow use of the ContainerLogger with the External Containerizer.
Date Mon, 14 Dec 2015 23:47:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41166/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 3:47 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Migrate initialization of the ContainerLogger into the Containerizer itself.


Summary (updated)
-----------------

Logger Module: Explicitly disallow use of the ContainerLogger with the External Containerizer.


Bugs: MESOS-4088
    https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description (updated)
-------

Using the `ContainerLogger` with the `ExternalContainerizer` is not supported at the moment.
 We explicitly disallowed the combination, so that there are no incorrect assumptions.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d 

Diff: https://reviews.apache.org/r/41166/diff/


Testing
-------

This is tested later in the review chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message